ericm-db commented on PR #48066: URL: https://github.com/apache/spark/pull/48066#issuecomment-2342538881
Sorry, thought about this a little more. I don't think this is actually fixing anything, in that we don't write metadata for every single batch, only every run. Say we have run a query for 5 batches, and then stopped it, so we wrote the metadata file for batch 0. If we want to get the metadata that is valid for batch 3 (metadata doesn't change mid-run), we would want to read the metadata file that was written for batch 0. I think your change actually breaks this behavior... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
