panbingkun commented on PR #47984: URL: https://github.com/apache/spark/pull/47984#issuecomment-2342733804
> @zhengruifeng This is a good idea. I think `ArrayBinarySearch` should be replaced by `invoke_binary_search_function(ToJavaArray(array_expr))`, and `ConstantFolding` should do the optimization automatically. For the new expression `ToJavaArray`, it can create primitive java array if the element type is primitive type and not nullable. @zhengruifeng @cloud-fan The latest logic based on `ToJavaType` has been submitted. Please help review it when you have free time, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
