panbingkun commented on code in PR #48073:
URL: https://github.com/apache/spark/pull/48073#discussion_r1754003297
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -1969,13 +1969,10 @@ case class FormatString(children: Expression*) extends
Expression with ImplicitC
if (pattern == null) {
null
} else {
- val sb = new StringBuffer()
- val formatter = new java.util.Formatter(sb, Locale.US)
-
+ val formatter = new java.util.Formatter(Locale.US)
val arglist = children.tail.map(_.eval(input).asInstanceOf[AnyRef])
- formatter.format(pattern.asInstanceOf[UTF8String].toString, arglist: _*)
-
- UTF8String.fromString(sb.toString)
+ UTF8String.fromString(
+ formatter.format(pattern.asInstanceOf[UTF8String].toString, arglist:
_*).toString)
Review Comment:
<img width="788" alt="image"
src="https://github.com/user-attachments/assets/5f52c524-7ed1-49d8-833b-f18f37ac462d";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
