LuciferYang commented on code in PR #48080:
URL: https://github.com/apache/spark/pull/48080#discussion_r1755226880


##########
sql/connect/server/pom.xml:
##########
@@ -111,7 +111,6 @@
       <groupId>org.apache.spark</groupId>
       <artifactId>spark-protobuf_${scala.binary.version}</artifactId>
       <version>${project.version}</version>
-      <type>test-jar</type>

Review Comment:
   If `<type>test-jar</type>` is used, then during maven testing it will 
attempt to fetch `spark-protobuf_2.13-4.0.0-SNAPSHOT-tests.jar`,  but what the 
tests actually need is `spark-protobuf_2.13-4.0.0-SNAPSHOT.jar`, so this tag 
should not be added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to