ericm-db commented on code in PR #48067:
URL: https://github.com/apache/spark/pull/48067#discussion_r1755538524
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala:
##########
@@ -1708,6 +1713,102 @@ class TransformWithStateSuite extends
StateStoreMetricsTest
}
}
}
+
+ test("transformWithState - verify that no metadata and schema logs are
purged after" +
Review Comment:
Oh we already have a test case for this here: `"transformWithState - verify
that metadata and schema logs are purged"`
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateSchemaCompatibilityChecker.scala:
##########
@@ -275,10 +280,20 @@ object StateSchemaCompatibilityChecker {
if (storeConf.stateSchemaCheckEnabled && result.isDefined) {
throw result.get
}
- val schemaFileLocation = newSchemaFilePath match {
- case Some(path) => path.toString
- case None => checker.schemaFileLocation.toString
+ val schemaFileLocation = if (evolvedSchema) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
