EnricoMi commented on code in PR #45728:
URL: https://github.com/apache/spark/pull/45728#discussion_r1758473162


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala:
##########
@@ -104,6 +104,13 @@ private[spark] class KubernetesClusterSchedulerBackend(
     conf.getOption("spark.app.id").getOrElse(appId)
   }
 
+  override def getDriverAttributes: Option[Map[String, String]] = Some(Map(

Review Comment:
   I have replaced this with `"SPARK_DRIVER_ATTRIBUTE_*" environment variables, 
similar to `"SPARK_EXECUTOR_ATTRIBUTE_". When `spark.ui.custom.driver.log.url` 
is defined, some driver attribute env vars are added just like in 
   #47692.



##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala:
##########
@@ -104,6 +104,13 @@ private[spark] class KubernetesClusterSchedulerBackend(
     conf.getOption("spark.app.id").getOrElse(appId)
   }
 
+  override def getDriverAttributes: Option[Map[String, String]] = Some(Map(

Review Comment:
   I have replaced this with `"SPARK_DRIVER_ATTRIBUTE_*" environment variables, 
similar to `"SPARK_EXECUTOR_ATTRIBUTE_". When `spark.ui.custom.driver.log.url` 
is defined, some driver attribute env vars are added just like in #47692.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to