zhipengmao-db commented on code in PR #47614: URL: https://github.com/apache/spark/pull/47614#discussion_r1758982153
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/Column.java: ########## @@ -113,6 +125,12 @@ static Column create( @Nullable String generationExpression(); + /** + * Returns the identity column specification of this table column. Null means no identity column. + */ + @Nullable + IdentityColumnSpec identityColumnSpec(); Review Comment: Great catch! We blocked generation expression to be specified with identity column in SQL syntax but we did not block `defaultValue` to be specified with identity column. Will provide a fix in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
