dtenedor commented on code in PR #48047:
URL: https://github.com/apache/spark/pull/48047#discussion_r1759320948
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala:
##########
@@ -880,4 +881,20 @@ class SparkSqlParserSuite extends AnalysisTest with
SharedSparkSession {
parser.parsePlan("SELECT\u30001") // Unicode ideographic space
}
// scalastyle:on
+
+ test("Operator pipe SQL syntax") {
+ withSQLConf(SQLConf.OPERATOR_PIPE_SYNTAX_ENABLED.key -> "true") {
Review Comment:
I tried removing it, but the test failed :) it seems like
`SparkSqlParserSuite` is not triggering `Utils.isTesting` for some reason. (It
does seem to work for `SQLQueryTestSuite`.)
<img width="961" alt="image"
src="https://github.com/user-attachments/assets/d2d820aa-751f-44cd-bf8d-e7fc5482234f";>
##########
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ThriftServerQueryTestSuite.scala:
##########
@@ -103,7 +103,8 @@ class ThriftServerQueryTestSuite extends SQLQueryTestSuite
with SharedThriftServ
// SPARK-42921
"timestampNTZ/datetime-special-ansi.sql",
// SPARK-47264
- "collations.sql"
+ "collations.sql",
+ "pipe-operators.sql"
Review Comment:
good question; previously I found it was flaky and failing sometimes because
it wasn't sorting the output result rows for some reason.
But it again now with a python script running it 25 times locally, it seems
to be passing now. I can re-enable the test here.
11:54
I can re-enable it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
