srielau commented on PR #48087:
URL: https://github.com/apache/spark/pull/48087#issuecomment-2350054269
An we discuss the name? Are there any other collations? Is there
precedence? Can we lean into what we did for keywords function?
Sent from my iPhone
On Sep 13, 2024, at 3:02 AM, Maxim Gekk ***@***.***> wrote:
@MaxGekk commented on this pull request.
________________________________
In
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala<https://github.com/apache/spark/pull/48087#discussion_r1758576610>:
> + SYSTEM BUILTIN UTF8_BINARY NULL NULL ACCENT_SENSITIVE
CASE_SENSITIVE NO_PAD NULL
+ SYSTEM BUILTIN UTF8_LCASE NULL NULL ACCENT_SENSITIVE
CASE_INSENSITIVE NO_PAD NULL
I would replace this LIMIT by WHERE which always returns one row, to don't
depend on order and how LIMIT behaves.
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/spark/pull/48087#discussion_r1758576610>, or
unsubscribe<https://github.com/notifications/unsubscribe-auth/AA22CFHCAGKZHSXT3QNJPHDZWKZ3FAVCNFSM6AAAAABODCERQ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMBSG4YDGNJTGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
