MaxGekk commented on code in PR #48118:
URL: https://github.com/apache/spark/pull/48118#discussion_r1761353753
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -5309,6 +5309,11 @@
"Subquery expressions are not supported within higher-order
functions. Please remove all subquery expressions from higher-order functions
and then try the query again."
]
},
+ "INLINE_TABLE_CONTAINS_SCALAR_SUBQUERY" : {
Review Comment:
Let's make it shorter since it could appear in users docs:
```suggestion
"SCALAR_SUBQUERY_IN_VALUES" : {
```
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -5309,6 +5309,11 @@
"Subquery expressions are not supported within higher-order
functions. Please remove all subquery expressions from higher-order functions
and then try the query again."
]
},
+ "INLINE_TABLE_CONTAINS_SCALAR_SUBQUERY" : {
+ "message" : [
+ "Scalar subqueries inside VALUES clause are not supported."
Review Comment:
The parent's error format has already the words `not supported`. See the
entire error message:
```
Unsupported subquery expression: Scalar subqueries inside VALUES clause are
not supported.
```
Please, leave it as:
```suggestion
"Scalar subqueries in the VALUES clause."
```
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -4909,6 +4909,24 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
)
}
}
+
+ test(
+ "SPARK-49659: Scalar subqueries inside VALUES clause must produce " +
+ "UNSUPPORTED_FEATURE.INLINE_TABLE_CONTAINS_SCALAR_SUBQUERY error"
+ ) {
Review Comment:
```suggestion
test("SPARK-49659: Unsupported scalar subqueries in VALUES") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
