hvanhovell commented on code in PR #48120:
URL: https://github.com/apache/spark/pull/48120#discussion_r1761452374
##########
sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala:
##########
@@ -145,9 +147,11 @@ class UDFRegistration private[sql] (functionRegistry:
FunctionRegistry)
* @param returnDataType return type of udf. If it is null, spark would try
to infer
* via reflection.
*/
- private[sql] def registerJava(name: String, className: String,
returnDataType: DataType): Unit = {
+ def registerJava(name: String, className: String, returnDataType: DataType):
Unit = {
Review Comment:
I am not against this. I am trying to understand the user facing
consequences though. I'd probably prefer that we add support for Scala UDFs as
well. That can be done in a follow-up though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
