wangyum commented on code in PR #48128:
URL: https://github.com/apache/spark/pull/48128#discussion_r1762224657
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/RebaseDateTime.scala:
##########
@@ -285,12 +285,12 @@ object RebaseDateTime {
}
// Loads rebasing info from an JSON file. JSON records in the files should
conform to
- // `JsonRebaseRecord`. AnyRefMap is used here instead of Scala's immutable
map because
- // it is 2 times faster in DateTimeRebaseBenchmark.
- private[sql] def loadRebaseRecords(fileName: String): AnyRefMap[String,
RebaseInfo] = {
+ // `JsonRebaseRecord`. Mutable HashMap is used here instead of AnyRefMap due
to SPARK-49491.
+ private[sql] def loadRebaseRecords(fileName: String):
mutable.HashMap[String, RebaseInfo] = {
Review Comment:
```suggestion
// `JsonRebaseRecord`. HashMap is used here instead of Scala's immutable
map because
// it is 2 times faster in DateTimeRebaseBenchmark.
private[sql] def loadRebaseRecords(fileName: String): HashMap[String,
RebaseInfo] = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
