HyukjinKwon commented on code in PR #48126:
URL: https://github.com/apache/spark/pull/48126#discussion_r1762353818
##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala:
##########
@@ -43,7 +43,8 @@ private[deploy] class SparkSubmitArguments(args: Seq[String],
env: Map[String, S
extends SparkSubmitArgumentsParser with Logging {
var maybeMaster: Option[String] = None
// Global defaults. These should be keep to minimum to avoid confusing
behavior.
- def master: String = maybeMaster.getOrElse("local[*]")
+ def master: String =
+ maybeMaster.getOrElse(System.getProperty("spark.test.master", "local[*]"))
Review Comment:
The change is fine but just curious. Why can't we just set `spark.master`
instead? The Python documentation build actually works fine in my mac fwiw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
