HyukjinKwon commented on code in PR #48122:
URL: https://github.com/apache/spark/pull/48122#discussion_r1762465881
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -2498,7 +2498,7 @@ class SparkConnectPlanner(
if (isCommand) {
// Convert the results to Arrow.
val schema = df.schema
- val maxBatchSize =
(SparkEnv.get.conf.get(CONNECT_GRPC_ARROW_MAX_BATCH_SIZE) * 0.7).toLong
+ val maxBatchSize = (ConnectCommon.CONNECT_GRPC_MAX_MESSAGE_SIZE *
0.7).toLong
Review Comment:
If this is more performance in most cases, I think we should change the
default value of `CONNECT_GRPC_ARROW_MAX_BATCH_SIZE` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
