MaxGekk commented on code in PR #46320:
URL: https://github.com/apache/spark/pull/46320#discussion_r1762554266
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/types/StructTypeSuite.scala:
##########
@@ -576,7 +576,7 @@ class StructTypeSuite extends SparkFunSuite with SQLHelper {
.putString(ResolveDefaultColumns.EXISTS_DEFAULT_COLUMN_METADATA_KEY,
"invalid")
.putString(ResolveDefaultColumns.CURRENT_DEFAULT_COLUMN_METADATA_KEY, "invalid")
.build())))
- assert(intercept[AnalysisException] {
+ assert(intercept[SparkException] {
Review Comment:
Could you use `checkError`, please.
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/types/StructTypeSuite.scala:
##########
@@ -592,7 +592,7 @@ class StructTypeSuite extends SparkFunSuite with SQLHelper {
ResolveDefaultColumns.CURRENT_DEFAULT_COLUMN_METADATA_KEY,
"(SELECT 'abc' FROM missingtable)")
.build())))
- assert(intercept[AnalysisException] {
+ assert(intercept[SparkException] {
Review Comment:
ditto: use `checkError`
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -3548,17 +3548,14 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase with Compilat
}
def failedToParseExistenceDefaultAsLiteral(fieldName: String, defaultValue:
String): Throwable = {
- new AnalysisException(
- errorClass = "_LEGACY_ERROR_TEMP_1344",
- messageParameters = Map(
- "fieldName" -> fieldName,
- "defaultValue" -> defaultValue))
+ SparkException.internalError(s"parse existence default as literal err," +
Review Comment:
@dtenedor kindly ping you. Please, have a look at the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
