mridulm commented on code in PR #46805:
URL: https://github.com/apache/spark/pull/46805#discussion_r1763097763
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java:
##########
@@ -161,6 +172,18 @@ public void getHostLocalDirs(
String[] execIds,
CompletableFuture<Map<String, String[]>> hostLocalDirsCompletable) {
checkInit();
+ int maxRetries = transportConf.maxIORetries();
+ int retryWaitTime = transportConf.ioRetryWaitTimeMs();
+ boolean enableSaslRetries = transportConf.enableSaslRetries();
+ retry(0, 0, maxRetries, enableSaslRetries, retryWaitTime,
+ () -> getHostLocalDirsInternal(host, port, execIds),
hostLocalDirsCompletable);
Review Comment:
Since `ScheduledExecutorService` has a fixed core pool size, a large (or
small) number of core thread size has their own potentially impacts.
Given how infrequent this is going to be, imo we should use what
`RetryingBlockTransferor` does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
