tedyu commented on PR #48116:
URL: https://github.com/apache/spark/pull/48116#issuecomment-2356241730
Here is why I moved the `sort` call:
```
if (stateSchemaVersion == SCHEMA_FORMAT_V3 &&
colFamiliesAddedOrRemoved) {
```
when `colFamiliesAddedOrRemoved` is false, the call to `createSchemaFile`
would be skipped and there is no need to sort.
Effectively the sorting is done lazily.
What do you think, @dongjoon-hyun ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
