dongjoon-hyun commented on code in PR #47980:
URL: https://github.com/apache/spark/pull/47980#discussion_r1764023300
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/internal/ConnectRuntimeConfig.scala:
##########
@@ -14,72 +14,43 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.spark.sql
+package org.apache.spark.sql.internal
import org.apache.spark.connect.proto.{ConfigRequest, ConfigResponse, KeyValue}
import org.apache.spark.internal.Logging
+import org.apache.spark.sql.RuntimeConfig
import org.apache.spark.sql.connect.client.SparkConnectClient
/**
* Runtime configuration interface for Spark. To access this, use
`SparkSession.conf`.
*
* @since 3.4.0
*/
-class RuntimeConfig private[sql] (client: SparkConnectClient) extends Logging {
+class ConnectRuntimeConfig private[sql] (client: SparkConnectClient)
Review Comment:
This looks like a breaking change at API level.
- I'm wondering if this is okay, @hvanhovell ?
- In addition, please fix `@since 3.4.0` tag because `ConnectRuntimeConfig`
only exists after 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
