xil-db commented on PR #48127: URL: https://github.com/apache/spark/pull/48127#issuecomment-2359380286
> I don't quite agree with this. The underlying catalog/data source may be case-sensitive and It's important to keep the query schema(column names) unchanged Yeah, I think that's a fair point. Don't have the full context here, I assume the intention of this PR is to avoid certain "false-alarms" raised by this validation, but if `AggregatePushdownThroughJoins` changes the column from `ppmonth` to `Ppmonth` with `spark.sql.caseSensitive` set to true, then we'd have a true alarm. Maybe I'm missing something, maybe it'd be better to just fix `AggregatePushdownThroughJoins` to avoid changing the column names regardless of the setting of `spark.sql.caseSensitive`. cc @averyqi-db -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
