zhengruifeng commented on code in PR #48157:
URL: https://github.com/apache/spark/pull/48157#discussion_r1766371748
##########
python/pyspark/sql/functions/builtin.py:
##########
@@ -6031,26 +6031,67 @@ def count_min_sketch(
----------
col : :class:`~pyspark.sql.Column` or str
target column to compute on.
- eps : :class:`~pyspark.sql.Column` or str
+ eps : :class:`~pyspark.sql.Column` or float
relative error, must be positive
- confidence : :class:`~pyspark.sql.Column` or str
+
+ .. versionchanged:: 4.0.0
+ `eps` now accepts float value.
+
+ confidence : :class:`~pyspark.sql.Column` or float
confidence, must be positive and less than 1.0
- seed : :class:`~pyspark.sql.Column` or str
+
+ .. versionchanged:: 4.0.0
+ `confidence` now accepts float value.
+
+ seed : :class:`~pyspark.sql.Column` or int
Review Comment:
nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
