bogao007 commented on code in PR #47933:
URL: https://github.com/apache/spark/pull/47933#discussion_r1769332084
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/TransformWithStateInPandasStateServer.scala:
##########
@@ -232,23 +349,53 @@ class TransformWithStateInPandasStateServer(
outputStream.write(responseMessageBytes)
}
- private def initializeValueState(
- stateName: String,
- schemaString: String,
- ttlDurationMs: Option[Int]): Unit = {
- if (!valueStates.contains(stateName)) {
- val schema = StructType.fromString(schemaString)
- val state = if (ttlDurationMs.isEmpty) {
- statefulProcessorHandle.getValueState[Row](stateName,
Encoders.row(schema))
- } else {
- statefulProcessorHandle.getValueState(
- stateName, Encoders.row(schema),
TTLConfig(Duration.ofMillis(ttlDurationMs.get)))
- }
- val valueRowDeserializer =
ExpressionEncoder(schema).resolveAndBind().createDeserializer()
- valueStates.put(stateName, (state, schema, valueRowDeserializer))
- sendResponse(0)
- } else {
- sendResponse(1, s"state $stateName already exists")
+ private def initializeStateVariable(
+ stateName: String,
+ schemaString: String,
+ stateVariable: String,
Review Comment:
done
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/TransformWithStateInPandasStateServer.scala:
##########
@@ -232,23 +349,53 @@ class TransformWithStateInPandasStateServer(
outputStream.write(responseMessageBytes)
}
- private def initializeValueState(
- stateName: String,
- schemaString: String,
- ttlDurationMs: Option[Int]): Unit = {
- if (!valueStates.contains(stateName)) {
- val schema = StructType.fromString(schemaString)
- val state = if (ttlDurationMs.isEmpty) {
- statefulProcessorHandle.getValueState[Row](stateName,
Encoders.row(schema))
- } else {
- statefulProcessorHandle.getValueState(
- stateName, Encoders.row(schema),
TTLConfig(Duration.ofMillis(ttlDurationMs.get)))
- }
- val valueRowDeserializer =
ExpressionEncoder(schema).resolveAndBind().createDeserializer()
- valueStates.put(stateName, (state, schema, valueRowDeserializer))
- sendResponse(0)
- } else {
- sendResponse(1, s"state $stateName already exists")
+ private def initializeStateVariable(
+ stateName: String,
+ schemaString: String,
+ stateVariable: String,
+ ttlDurationMs: Option[Int]): Unit = {
+ val schema = StructType.fromString(schemaString)
+ val expressionEncoder = ExpressionEncoder(schema).resolveAndBind()
+ stateVariable match {
+ case "valueState" => if (!valueStates.contains(stateName)) {
+ val state = if (ttlDurationMs.isEmpty) {
+ statefulProcessorHandle.getValueState[Row](stateName,
Encoders.row(schema))
+ } else {
+ statefulProcessorHandle.getValueState(
+ stateName, Encoders.row(schema),
TTLConfig(Duration.ofMillis(ttlDurationMs.get)))
+ }
+ valueStates.put(stateName,
+ ValueStateInfo(state, schema,
expressionEncoder.createDeserializer()))
+ sendResponse(0)
+ } else {
+ sendResponse(1, s"Value state $stateName already exists")
+ }
+ case "listState" => if (!listStates.contains(stateName)) {
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
