dongjoon-hyun commented on code in PR #48189: URL: https://github.com/apache/spark/pull/48189#discussion_r1769366887
########## docs/configuration.md: ########## @@ -1222,6 +1222,19 @@ Apart from these, the following properties are also available, and may be useful </td> <td>2.2.1</td> </tr> +<tr> + <td><code>spark.shuffle.accurateBlockSkewedFactor</code></td> Review Comment: To @timlee0119 and @JoshRosen , shall we remove `.internal()` from the configuration definition together? https://github.com/apache/spark/blob/bdea09128760a5d36410cae2074f70a77e95c12b/core/src/main/scala/org/apache/spark/internal/config/package.scala#L1387-L1389 ########## docs/configuration.md: ########## @@ -1222,6 +1222,19 @@ Apart from these, the following properties are also available, and may be useful </td> <td>2.2.1</td> </tr> +<tr> + <td><code>spark.shuffle.accurateBlockSkewedFactor</code></td> Review Comment: In addition, the PR title looks wrong to me because we are touching `spark.shuffle.accurateBlockSkewedFactor` instead of `spark.sql.adaptive....`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
