cloud-fan commented on code in PR #47096:
URL: https://github.com/apache/spark/pull/47096#discussion_r1769485935
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -3027,6 +3027,9 @@ object Encode {
legacyCharsets: Boolean,
legacyErrorAction: Boolean): Array[Byte] = {
val toCharset = charset.toString
+ if (input.numBytes == 0 || "UTF-8".equalsIgnoreCase(toCharset)) {
Review Comment:
yea I think so. For the happy path it's still faster than doing the actual
encoding, and invalid utf8 bytes should be rare so it's ok to have an extra
`isValid` call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
