MaxGekk commented on code in PR #48196:
URL: https://github.com/apache/spark/pull/48196#discussion_r1770856642
##########
common/utils/src/main/java/org/apache/spark/SparkThrowable.java:
##########
@@ -35,19 +35,29 @@
*/
@Evolving
public interface SparkThrowable {
- // Succinct, human-readable, unique, and consistent representation of the
error category
- // If null, error class is not set
- String getErrorClass();
+ /**
+ * Succinct, human-readable, unique, and consistent representation of the
error condition.
+ * If null, error condition is not set.
+ */
+ String getCondition();
Review Comment:
IMHO, the `error` word is unnecessary. The interface is about errors, and I
don't think we should add `error` everywhere. In this logic we should add the
error to all methods:
- `getErrorMessageParameters`
- `getErrorQueryContext`
- `getErrorSqlContext`
And when you call `exception.getCondition`, do you expect a condition of
somewhat else of the exception/error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
