anishshri-db commented on code in PR #48205:
URL: https://github.com/apache/spark/pull/48205#discussion_r1772385512
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/state/StateDataSource.scala:
##########
@@ -153,10 +154,21 @@ class StateDataSource extends TableProvider with
DataSourceRegister with Logging
"No state variable names are defined for the transformWithState
operator")
}
+ val twsOperatorProperties =
TransformWithStateOperatorProperties.fromJson(operatorProperties)
+ val timeMode = twsOperatorProperties.timeMode
+ if (sourceOptions.readRegisteredTimers && timeMode ==
TimeMode.None().toString) {
+ throw StateDataSourceErrors.invalidOptionValue(READ_REGISTERED_TIMERS,
+ "Registered timers are not available in TimeMode=None.")
+ }
+
// if the state variable is not one of the defined/available state
variables, then we
// fail the query
- val stateVarName = sourceOptions.stateVarName.get
- val twsOperatorProperties =
TransformWithStateOperatorProperties.fromJson(operatorProperties)
+ val stateVarName = if (sourceOptions.readRegisteredTimers) {
+ TimerStateUtils.getTimerStateVarName(timeMode)
+ } else {
+ sourceOptions.stateVarName.get
+ }
Review Comment:
Actually prefer to keep this as it is
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/state/StateDataSourceTransformWithStateSuite.scala:
##########
@@ -481,4 +481,94 @@ class StateDataSourceTransformWithStateSuite extends
StateStoreMetricsTest
}
}
}
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
