TakawaAkirayo commented on code in PR #48200:
URL: https://github.com/apache/spark/pull/48200#discussion_r1774662293


##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -529,7 +529,7 @@ object SparkConnectService extends Logging {
 case class SparkListenerConnectServiceStarted(
     hostAddress: String,
     bindingPort: Int,
-    sparkConf: SparkConf,
+    sparkConf: Map[String, String],

Review Comment:
   The purpose is to send additional context, such as the spark.app.id set in 
SparkContext's _conf during startup, to the listener. This can be achieved 
through other means within the listener. I agree that we can remove this from 
the event.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to