srielau commented on code in PR #48242:
URL: https://github.com/apache/spark/pull/48242#discussion_r1775354297
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -70,6 +70,12 @@
],
"sqlState" : "42000"
},
+ "ANSI_DATE_TIME_FIELD_OUT_OF_BOUNDS" : {
+ "message" : [
+ "ANSI mode error: <message>. If necessary set <ansiConfig> to false to
bypass this error."
Review Comment:
This message makes no sense. The problem is not that ANIS mode is on. The
problem is that the value is out of bounds.
```suggestion
"ANSI mode error: <message>. If necessary set <ansiConfig> to false to
bypass this error."
```
We should produce a message as good as the existing one. We shoudl NOT just
WRAP the existing message.
State the unit: YEAR, MONTH, DAY, HOUR, MINUTE, SECOND
State the range for the unit
State the bad value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
