GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/6587
[SPARK-7269] [SQL] [WIP] Refactor the class AttributeReference
- The methods of `equals` and `hashCode` in case class `AttributeReference`
are quite confusing, as it doesn't work like normal case class.
- Besides, in semantic, `AttributeReference` should not care about the
`name`, which supposed to be the hint of binding attribute references.
- Remove the `semanticEquals` for `Expression`, this method is actually
redundant and hard to make an accurate definition for `Semantic Equals`.
I marked it as `WIP` for feedback / discussion.
Still,
- [ ] Refactor the `Alias` also? `Alias(child, "id")` is `semantically`
equals `Alias(child, "iD")` in a case insensitive system?
- [ ] Remove the `AttributeMap` or `AttributeSet` to simplify the code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenghao-intel/spark attr_ref
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/6587.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6587
----
commit 869d7cf7ef3f69f95b4ad1512404499fdee5182c
Author: Cheng Hao <[email protected]>
Date: 2015-06-02T14:02:24Z
refactor the AttributeReference
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
