LuciferYang commented on PR #48238: URL: https://github.com/apache/spark/pull/48238#issuecomment-2376131571
The code is OK for me, but it would be even better if we could continuously ensure that this behavior meets expectations by adding an additional test case. Also, could you provide more detailed information in the 'How was this patch tested?' section? The description 'In our internal hadoop cluster' is too opaque box; we need a reproducible verification method to allow reviewers to confirm that the issue truly exists and has been fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
