cloud-fan commented on code in PR #43796:
URL: https://github.com/apache/spark/pull/43796#discussion_r1776924601
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/aggregate/Aggregation.java:
##########
@@ -28,16 +28,7 @@
* @since 3.2.0
*/
@Evolving
-public final class Aggregation implements Serializable {
- private final AggregateFunc[] aggregateExpressions;
- private final Expression[] groupByExpressions;
-
- public Aggregation(AggregateFunc[] aggregateExpressions, Expression[]
groupByExpressions) {
- this.aggregateExpressions = aggregateExpressions;
- this.groupByExpressions = groupByExpressions;
- }
-
- public AggregateFunc[] aggregateExpressions() { return aggregateExpressions;
}
-
- public Expression[] groupByExpressions() { return groupByExpressions; }
+public record Aggregation(
Review Comment:
This is public API, are we sure this doesn't break binary compatibility?
@LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
