jovanpavl-db commented on code in PR #48265:
URL: https://github.com/apache/spark/pull/48265#discussion_r1778114253
##########
sql/api/src/main/scala/org/apache/spark/sql/internal/types/AbstractStringType.scala:
##########
@@ -46,9 +46,10 @@ case object StringTypeBinaryLcase extends AbstractStringType
{
}
/**
- * Use StringTypeAnyCollation for expressions supporting all possible
collation types.
+ * Use StringTypeWithCaseAccentSensitivity for expressions supporting all
collation types
+ * (binary and ICU) but limited to using case and accent sensitivity
specifiers.
*/
-case object StringTypeAnyCollation extends AbstractStringType {
+case object StringTypeWithCaseAccentSensitivity extends AbstractStringType {
Review Comment:
StringTypeAnyCollation is name that we shouldn't use for good. If collations
supports use of all specifiers, just embed it in the name to avoid any
confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
