HyukjinKwon commented on code in PR #48264:
URL: https://github.com/apache/spark/pull/48264#discussion_r1779283866
##########
sql/api/src/main/scala/org/apache/spark/sql/RuntimeConfig.scala:
##########
@@ -54,17 +54,20 @@ abstract class RuntimeConfig {
}
/**
- * Returns the value of Spark runtime configuration property for the given
key.
+ * Returns the value of Spark runtime configuration property for the given
key. If the key is
+ * not set yet, return `defaultValue` in its [[ConfigEntry]].
Review Comment:
I think real error is this:
```
```
[error] Generating
/__w/spark/spark/target/javaunidoc/org/apache/spark/sql/RuntimeConfig.html...
[error]
/__w/spark/spark/sql/api/target/java/org/apache/spark/sql/RuntimeConfig.java:13:1:
error: reference not found
[error] * not set yet, return <code>defaultValue</code> in its {@link
ConfigEntry}.
[error] ^
[error]
/__w/spark/spark/sql/api/target/java/org/apache/spark/sql/RuntimeConfig.java:25:1:
error: reference not found
[error] * {@link ConfigEntry} is not the desired one.
[error] ^
```
```
Let's just switch `[[ConfigEntry]]` to something else or remove it.
`ConfigEntry` isn't technically an API so there is no way for the end users to
see.
##########
sql/api/src/main/scala/org/apache/spark/sql/RuntimeConfig.scala:
##########
@@ -54,17 +54,20 @@ abstract class RuntimeConfig {
}
/**
- * Returns the value of Spark runtime configuration property for the given
key.
+ * Returns the value of Spark runtime configuration property for the given
key. If the key is
+ * not set yet, return `defaultValue` in its [[ConfigEntry]].
Review Comment:
I think real error is this:
```
[error] Generating
/__w/spark/spark/target/javaunidoc/org/apache/spark/sql/RuntimeConfig.html...
[error]
/__w/spark/spark/sql/api/target/java/org/apache/spark/sql/RuntimeConfig.java:13:1:
error: reference not found
[error] * not set yet, return <code>defaultValue</code> in its {@link
ConfigEntry}.
[error] ^
[error]
/__w/spark/spark/sql/api/target/java/org/apache/spark/sql/RuntimeConfig.java:25:1:
error: reference not found
[error] * {@link ConfigEntry} is not the desired one.
[error] ^
```
Let's just switch `[[ConfigEntry]]` to something else or remove it.
`ConfigEntry` isn't technically an API so there is no way for the end users to
see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
