cloud-fan commented on code in PR #48363:
URL: https://github.com/apache/spark/pull/48363#discussion_r1792020231
##########
sql/api/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -4061,7 +4061,14 @@ object functions {
* @group string_funcs
* @since 2.3.0
*/
- def ltrim(e: Column, trimString: String): Column = Column.fn("ltrim",
lit(trimString), e)
+ def ltrim(e: Column, trimString: String): Column = ltrim(e, lit(trimString))
+
+ /**
+ * Trim the specified character string from left end for the specified
string column.
+ * @group string_funcs
+ * @since 4.0.0
+ */
+ def ltrim(e: Column, trim: Column): Column = Column.fn("ltrim", trim, e)
Review Comment:
Is `trim` the expression for the trimString? Looks a bit weird to call this
parameter `trim`. It's also not consistent with the function doc of expression
`StringTrim`, which names this parameter as `trimStr`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
