uros-db commented on code in PR #48386:
URL: https://github.com/apache/spark/pull/48386#discussion_r1793047345
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -154,16 +154,24 @@ public static class Collation {
*/
public final boolean supportsLowercaseEquality;
+ /**
+ * Support for Space Trimming implies that that based on specifier (for
now only right trim)
+ * leading, trailing or both spaces are removed from the input string
before comparison.
+ */
+ public final boolean supportsSpaceTrimming;
+
public Collation(
String collationName,
String provider,
Collator collator,
Comparator<UTF8String> comparator,
String version,
ToLongFunction<UTF8String> hashFunction,
+ BiFunction<UTF8String, UTF8String, Boolean> equalsFunction,
boolean supportsBinaryEquality,
boolean supportsBinaryOrdering,
- boolean supportsLowercaseEquality) {
+ boolean supportsLowercaseEquality,
+ boolean supportsSpaceTrimming) {
Review Comment:
this is a good point, for example if we have "UTF8_BINARY_RTRIM", then it's
no longer "binaryEquality" per se
however, I suggest we visit this issue in a follow-up, additional assert
could be good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
