mrk-andreev commented on code in PR #48288:
URL: https://github.com/apache/spark/pull/48288#discussion_r1793360592
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/functions/ScalarFunction.java:
##########
@@ -149,7 +152,10 @@ public interface ScalarFunction<R> extends BoundFunction {
* @return a result value
*/
default R produceResult(InternalRow input) {
- throw new SparkUnsupportedOperationException("_LEGACY_ERROR_TEMP_3146");
+ throw new SparkUnsupportedOperationException(
+ "SCALAR_FUNCTION_NOT_COMPATIBLE",
+ Map.of("scalarFunc", QuotingUtils.quoteIdentifier(name()))
Review Comment:
> Could you fix indentation. Should be 2 gaps.
Fixed
> LGTM except of a comment. Also update PR's description:
> remove the link to JIRA ticket
> error-classes.json -> error-conditions.json
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
