cloud-fan commented on code in PR #48413:
URL: https://github.com/apache/spark/pull/48413#discussion_r1796324933
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -1010,21 +1018,40 @@ class AstBuilder extends DataTypeAstBuilder
// [EMPTY]
query
} else {
- throw
QueryParsingErrors.combinationQueryResultClausesUnsupportedError(ctx)
+ throw QueryParsingErrors.combinationQueryResultClausesUnsupportedError(
+ ctx, "ORDER BY/SORT BY/DISTRIBUTE BY/CLUSTER BY")
}
// WINDOWS
- val withWindow = withOrder.optionalMap(windowClause)(withWindowClause)
+ val withWindow = withOrder.optionalMap(windowClause) {
+ withWindowClause
+ }
+ if (forPipeOperators && windowClause != null) {
+ throw QueryParsingErrors.combinationQueryResultClausesUnsupportedError(
+ ctx, s"WINDOW clauses within SQL pipe operators")
+ }
// OFFSET
// - OFFSET 0 is the same as omitting the OFFSET clause
+ val offsetClause = "OFFSET"
val withOffset = withWindow.optional(offset) {
+ if (forPipeOperators && clause.nonEmpty) {
+ throw QueryParsingErrors.combinationQueryResultClausesUnsupportedError(
+ ctx, s"the $clause and $offsetClause clauses")
Review Comment:
shall we highlight it's only a limitation in the SQL pipe syntax?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
