MaxGekk commented on code in PR #48453:
URL: https://github.com/apache/spark/pull/48453#discussion_r1799086348
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala:
##########
@@ -81,7 +81,8 @@ class JsonInferSchema(options: JSONOptions) extends
Serializable with Logging {
*/
def infer[T](
json: RDD[T],
- createParser: (JsonFactory, T) => JsonParser): StructType = {
+ createParser: (JsonFactory, T) => JsonParser,
+ isReadFile: Boolean = true): StructType = {
Review Comment:
Do you really need the default value. It is called just from 2 places, and
from 2 places in tests where you set it wrongly actually because of the default
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
