neilramaswamy commented on code in PR #48438:
URL: https://github.com/apache/spark/pull/48438#discussion_r1798826476
##########
docs/streaming/apis-on-dataframes-and-datasets.md:
##########
@@ -436,7 +437,7 @@ Imagine our [quick
example](./getting-started.html#quick-example) is modified an
The result tables would look something like the following.
-
+
Review Comment:
I had originally believed that there was no cleaner way to do this, but let
me lay out an alternative. The main trickiness is that we pre-build HTML pages
to put under `/docs/<version>/`, so we cannot:
1. Use absolute paths, since those resolve under spark.apache.org, not
spark.apache.org/docs/<version>.
2. Use sibling paths, since doing `img/foo.png` on a
`docs/<version>/streaming/` page will resolve to `/streaming/img/`, and we have
our images under `/docs/<version>/img`.
However, one option is to actually move all streaming related images under
`/docs/<version>/streaming/img`. Then, all image usages in streaming doesn't
need any of this `rel_path_to_root` stuff. I originally didn't do this because
I wasn't sure if we had some special process for serving the content in
`docs/<version>/img` from a CDN, but it seems like it's being served by an
Apache web server (though I can't tell more from the Devtools).
Does that sound better to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
