hvanhovell commented on code in PR #48430:
URL: https://github.com/apache/spark/pull/48430#discussion_r1800295139
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/execution/SparkConnectPlanExecution.scala:
##########
@@ -144,6 +144,14 @@ private[execution] class
SparkConnectPlanExecution(executeHolder: ExecuteHolder)
sendBatch(bytes, count, offset)
offset += count
}
+ case cle @ (_: CollectLimitExec | _: CollectTailExec) =>
+ val rows = cle.executeCollect()
Review Comment:
I'd be nice if we could do this in a more streaming fashion. That is the
whole point of connect's custom collection code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
