MaxGekk commented on code in PR #48440:
URL: https://github.com/apache/spark/pull/48440#discussion_r1800645095
##########
core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala:
##########
@@ -245,7 +245,7 @@ class SparkThrowableSuite extends SparkFunSuite {
throw new SparkException("Arbitrary legacy message")
} catch {
case e: SparkThrowable =>
- assert(e.getCondition == null)
+ assert(e.getCondition == "_LEGACY_ERROR_TEMP_3264")
Review Comment:
we need this but as a part of assigning proper name to
`_LEGACY_ERROR_TEMP_3264`. For now, it is more important is to disallow raising
`SparkThrowable` without any error condition (class).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
