MaxGekk commented on code in PR #48454:
URL: https://github.com/apache/spark/pull/48454#discussion_r1801686514


##########
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala:
##########
@@ -352,6 +352,44 @@ class StringFunctionsSuite extends QueryTest with 
SharedSparkSession {
     // scalastyle:on
   }
 
+  test("UTF-8 string is valid") {
+    // scalastyle:off
+    checkAnswer(Seq("大千世界").toDF("a").selectExpr("is_valid_utf8(a)"), 
Row(true))

Review Comment:
   Could you call the new added functions from Scala/Java API instead of the 
registered functions, please. I would understand that eventually we invoke the 
SQL function, but the implementation might be changed in the future as it 
happened already. Please, invoke new functions directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to