ulysses-you commented on code in PR #48484:
URL: https://github.com/apache/spark/pull/48484#discussion_r1802324211


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -815,6 +818,12 @@ case class AdaptiveSparkPlanExec(
     }
   }
 
+  private def assertStageNotFailed(stage: QueryStageExec): Unit = {
+    if (stage.hasFailed) {
+      throw stage.error.get().get

Review Comment:
   Does this exception class and msg is same with the first one ? Shall we 
follow the behavior in `cleanUpAndThrowException` ?
   
   How about holding a plan level exception? We now cache the plan for every 
query, it seems hold a plan level exception is reasonable (even without aqe).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to