mihailom-db commented on code in PR #48436:
URL: https://github.com/apache/spark/pull/48436#discussion_r1803060196


##########
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##########
@@ -106,3 +109,20 @@ case object StringType extends StringType(0) {
     new StringType(collationId)

Review Comment:
   nit: Should we rename these values here to _collationId, just for 
consistency?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to