JoshRosen commented on code in PR #48391:
URL: https://github.com/apache/spark/pull/48391#discussion_r1803469928
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala:
##########
@@ -94,10 +95,11 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]]
* All Attributes that appear in expressions from this operator. Note that
this set does not
* include attributes that are implicitly referenced by being passed through
to the output tuple.
*/
- @transient
Review Comment:
Making `Lazy#value` a `@transient` field is an interesting proposal and
seems promising.
If we do this, I think we should consider changing the name to
`TransientLazy` or `LazyTransient` for the sake of making the transient aspect
more salient to a reader / reviewer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
