HyukjinKwon commented on code in PR #48364:
URL: https://github.com/apache/spark/pull/48364#discussion_r1803945758
##########
python/pyspark/sql/tests/test_connect_compatibility.py:
##########
@@ -17,161 +17,234 @@
import unittest
import inspect
+import functools
from pyspark.testing.connectutils import should_test_connect,
connect_requirement_message
from pyspark.testing.sqlutils import ReusedSQLTestCase
from pyspark.sql.classic.dataframe import DataFrame as ClassicDataFrame
from pyspark.sql.classic.column import Column as ClassicColumn
from pyspark.sql.session import SparkSession as ClassicSparkSession
+from pyspark.sql.catalog import Catalog as ClassicCatalog
if should_test_connect:
from pyspark.sql.connect.dataframe import DataFrame as ConnectDataFrame
from pyspark.sql.connect.column import Column as ConnectColumn
from pyspark.sql.connect.session import SparkSession as ConnectSparkSession
+ from pyspark.sql.connect.catalog import Catalog as ConnectCatalog
class ConnectCompatibilityTestsMixin:
- def get_public_methods(self, cls):
+ def _get_public_methods(self, cls):
Review Comment:
it doesn't need to be with `_` prefix. nested funcs are fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
