yaooqinn commented on code in PR #48494:
URL: https://github.com/apache/spark/pull/48494#discussion_r1804455672
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala:
##########
@@ -1585,6 +1585,17 @@ class ParquetIOSuite extends QueryTest with ParquetTest
with SharedSparkSession
}
}
}
+
+ test("SPARK-49991: Respect 'mapreduce.output.basename' to generate file
names") {
+ withTempPath { dir =>
+ withSQLConf("mapreduce.output.basename" -> "apachespark") {
+ spark.range(1).coalesce(1).write.parquet(dir.getCanonicalPath)
+ val df = spark.read.parquet(dir.getCanonicalPath)
+ assert(df.inputFiles.head.contains("apachespark"))
Review Comment:
For checkpoint* you have mentioned, it looks safe to me in a roundtrip.
In addition to those mentioned, there is another instance in
SparkHadoopWriter where it is hardcoded. Since this affects the underlying RDD
APIs, I plan to leave it unchanged in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
