uros-db commented on code in PR #48495:
URL: https://github.com/apache/spark/pull/48495#discussion_r1805051446
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -3646,10 +3646,12 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase with Compilat
)
}
- def implicitCollationMismatchError(): Throwable = {
+ def implicitCollationMismatchError(implicitTypes: Seq[String]): Throwable = {
new AnalysisException(
errorClass = "COLLATION_MISMATCH.IMPLICIT",
- messageParameters = Map.empty
+ messageParameters = Map(
+ "implicitTypes" -> implicitTypes.map(toSQLId).mkString(", ")
Review Comment:
given that this is how it's currently done for `COLLATION_MISMATCH.IMPLICIT`
(code above this), how about we keep this PR as it is (given the scope)
then I propose to follow up later to correct both explicit & implicit
QueryCompilationErrors like you suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
