harshmotw-db commented on code in PR #48379:
URL: https://github.com/apache/spark/pull/48379#discussion_r1805489449
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLRegexpSuite.scala:
##########
@@ -96,6 +98,36 @@ class CollationSQLRegexpSuite
}
}
+ test("RegExpReplace throws the right exception when replace fails on a
particular row") {
Review Comment:
Good question. I didn't want to create a whole new test suite for this small
test. Therefore, it put it in the only SQL test suite I could find for
regexp-expressions. The other `RegexpExpressionsSuite.scala` doesn't do
end-to-end SQL testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]