Yikun commented on PR #48520: URL: https://github.com/apache/spark/pull/48520#issuecomment-2421209279
Have offline discussion with ruifeng: 1. we need to also refresh the image cache job, otherwise cache speed up will not work: https://github.com/apache/spark/blob/master/.github/workflows/build_infra_images_cache.yml - Fix paths - add a step for doc image cache the infra image cache is a separate job will be triggered when the dockerfile PR is merged (we first make sure ci passed and the dockerfile do the right fix/upgrade/change, then do the [post fresh](https://github.com/apache/spark/blob/75b86667ee7607d3523d7ce75c1022752142a443/.github/workflows/build_infra_images_cache.yml#L24)) 2. For branch cache/job images, we could keep original behavior that means: **For branch jobs (doc and test):** cache: ghcr.io/apache/spark/apache-spark-github-action-image-cache:branch-3.5 job: apache-spark-ci-image:${{ inputs.branch }}-${{ github.run_id }} **For master jobs:** test: cache: ghcr.io/apache/spark/apache-spark-github-action-image-cache:branch-3.5 job: apache-spark-ci-image:${{ inputs.branch }}-${{ github.run_id }} doc: cache: ghcr.io/apache/spark/apache-spark-github-action-image-**docs**-cache:branch-3.5 job: apache-spark-ci-image-**docs**:${{ inputs.branch }}-${{ github.run_id }} -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
