zhengruifeng commented on code in PR #48536: URL: https://github.com/apache/spark/pull/48536#discussion_r1806541914
########## python/pyspark/sql/functions/builtin.py: ########## @@ -9678,7 +9678,7 @@ def from_utc_timestamp(timestamp: "ColumnOrName", tz: Union[Column, str]) -> Col @_try_remote_functions -def to_utc_timestamp(timestamp: "ColumnOrName", tz: "ColumnOrName") -> Column: Review Comment: good catch! `tz` is a literal string here ########## python/pyspark/sql/functions/builtin.py: ########## @@ -14533,7 +14533,7 @@ def arrays_overlap(a1: "ColumnOrName", a2: "ColumnOrName") -> Column: @_try_remote_functions def slice( - x: "ColumnOrName", start: Union["ColumnOrName", int], length: Union["ColumnOrName", int] Review Comment: it will be a breaking change for `slice(x=..., start=...)` since we have already documented the parameters `x`, I think we should not change hare, instead we can change the connect side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
